search

lightninglabs / lightning-terminal

Lightning Terminal: Your Home for Lightning Liquidity
MIT License
488 stars 82 forks source link

itest: Add custom channels with grouped asset test #781

Closed GeorgeTsagk closed 2 days ago

GeorgeTsagk commented 3 days ago

Description

This PR adds a new itest that uses a grouped asset, in order to tackle some of the issues discovered in https://github.com/lightninglabs/taproot-assets/issues/947

Closes https://github.com/lightninglabs/taproot-assets/issues/957

guggero commented 3 days ago

Looks like the grouped asset itest fails consistently when sending a payment. Does that happen as well for you locally?

GeorgeTsagk commented 3 days ago

Looks like the grouped asset itest fails consistently when sending a payment. Does that happen as well for you locally?

Nope, locally it passes consistently, and on Github CI it's flaky

guggero commented 2 days ago

The flake will be fixed by https://github.com/lightningnetwork/lnd/pull/8871. Not sure if we should get this in while flakey and then wait for the CI to become fully green in https://github.com/lightninglabs/lightning-terminal/pull/782 which bumps all dependencies?

GeorgeTsagk commented 2 days ago

The flake will be fixed by https://github.com/lightningnetwork/lnd/pull/8871. Not sure if we should get this in while flakey and then wait for the CI to become fully green in https://github.com/lightninglabs/lightning-terminal/pull/782 which bumps all dependencies?

I'm fine both ways, since we know it's a flake we could hit the merge prematurely