search

lightninglabs / lnc-web

Lightning Node Connect npm module for web
https://docs.lightning.engineering/lightning-network-tools/lightning-terminal/lnc-npm
48 stars 17 forks source link

Feature/yarn #65

Closed adam2k closed 1 year ago

adam2k commented 2 years ago

Switch from npm to yarn to be more consistent with the other LND projects (yarn is used in lightning-terminal, builders-guide-sample-app).

A similar change could also be applied to lnc-core. This project is still using npm.

Test Steps:

  1. To confirm & reproduce the yarn.lock file run yarn import in each of the directories containing a package-lock.json file.
  2. Make sure the yarn commands and demo applications still work as expected
kaloudis commented 2 years ago

Looks good. Only thing is I'm unsure if yarn will work in the GitHub workflows.

Also highlights that it doesn't run on PRs from external contributors (such as this one). Will investigate.

kaloudis commented 1 year ago

@adam2k after investigating, it should work fine. if you rebase and fix the conflicts I'll merge this in

kaloudis commented 1 year ago

Closing in favor of https://github.com/lightninglabs/lnc-web/pull/73

@adam2k - appreciate your efforts here so I made you a co-author on the new PR. The only major thing I changed was using yarn's version locking in the GitHub Action workflows: yarn install --frozen-lockfile