search

lightninglabs / lndmon

🔎lndmon: A drop-in monitoring solution for your lnd node using Prometheus+Grafana
MIT License
149 stars 47 forks source link

HTLC stream still active when --disablehtlc is set #103

Closed mrfelton closed 4 months ago

mrfelton commented 5 months ago

With the --disablehtlc switch enabled, the htlc stream is still active.

It's visible in the log outgoing, which continues to print log messages related to the htlc stream:

2024-01-21 23:27:12.097 [INF] HTLC: resolved htlc: (Chan ID=825371:1478:1, HTLC ID=553) -> (Chan ID=814836:461:0, HTLC ID=0) original forward not found
2024-01-21 23:27:22.758 [INF] HTLC: resolved htlc: (Chan ID=822334:2670:3, HTLC ID=317070) -> (Chan ID=814781:2014:1, HTLC ID=0) original forward not found
2024-01-21 23:27:40.875 [INF] HTLC: resolved htlc: (Chan ID=814836:461:0, HTLC ID=788227) -> (Chan ID=815499:1205:0, HTLC ID=0) original forward not found
2024-01-21 23:27:57.623 [INF] HTLC: resolved htlc: (Chan ID=822334:2670:3, HTLC ID=317106) -> (Chan ID=814781:2014:1, HTLC ID=0) original forward not found
2024-01-21 23:29:21.002 [INF] HTLC: resolved htlc: (Chan ID=823849:1703:5, HTLC ID=94805) -> (Chan ID=815499:1205:0, HTLC ID=0) original forward not found
2024-01-21 23:29:28.342 [INF] HTLC: resolved htlc: (Chan ID=822334:2670:3, HTLC ID=317190) -> (Chan ID=814781:2014:1, HTLC ID=0) original forward not found
2024-01-21 23:29:29.666 [INF] HTLC: resolved htlc: (Chan ID=822334:2670:3, HTLC ID=317193) -> (Chan ID=814781:2014:1, HTLC ID=0) original forward not found
2024-01-21 23:30:24.975 [INF] HTLC: resolved htlc: (Chan ID=822334:2670:3, HTLC ID=317273) -> (Chan ID=814781:2014:1, HTLC ID=0) original forward not found
2024-01-21 23:30:36.889 [INF] HTLC: resolved htlc: (Chan ID=822334:2670:3, HTLC ID=317294) -> (Chan ID=814781:2014:1, HTLC ID=0) original forward not found
2024-01-21 23:31:13.148 [INF] HTLC: resolved htlc: (Chan ID=823849:1703:5, HTLC ID=94827) -> (Chan ID=814781:2014:1, HTLC ID=0) original forward not found

Relevant code: https://github.com/lightninglabs/lndmon/blob/2d4e987b3f0414a3dfe51f05e672867e3257aeb0/collectors/prometheus.go#L95-L109

Is there any value in connecting to and monitoring the stream if we aren't collecting any metrics from it?

Roasbeef commented 5 months ago

Yep you're right, we shouldn't init it here if the flag is specified: https://github.com/lightninglabs/lndmon/blob/2d4e987b3f0414a3dfe51f05e672867e3257aeb0/collectors/prometheus.go#L95

mrfelton commented 4 months ago

Fixed via https://github.com/lightninglabs/lndmon/pull/106