lightninglabs / loop

Lightning Loop: A Non-Custodial Off/On Chain Bridge
MIT License
552 stars 116 forks source link

Charge for failed Loop Outs (30,000 Sats each time) #449

Open ElChopChop opened 2 years ago

ElChopChop commented 2 years ago

I've tried to Loop Out twice, but both times it's failed and has charged me 30,000 Sats (each time) for "Cost Server". I thought I shouldn't be charged if the Loop Out failed.

Expected behavior

If the Loop Out fails, I was expecting there to be no charge.

Actual behavior

I was charged 30,000 for each failed Loop Out. My node is also reflecting these charges (identified as "Prepay" in the screenshot attached)

image image

To reproduce

I have reproduced the issue by conducting the Loop Out twice, both times is failed and both times I was charged 30,000 Sats.

System information

LIghtning Terminal

Did you install using Umbrel? Yes

CMD or Lightning Terminal UI? Lightning Terminal UI

0.11.2-beta from Umbrel app store

Windows 10 Intel(R) Core(TM) i5-1035G4 CPU @ 1.10GHz 1.50 GHz 250GB SSD NTFS

Windows 10 Home Version 20H2

alexbosworth commented 2 years ago

Do you have any additional logs?

ElChopChop commented 2 years ago

Hi @alexbosworth, I have the below; does that help?

If not, how would I go about generating the additional logs? Thanks!!

image image

alexbosworth commented 2 years ago

Logs would be in the dir where you have your LN node data, that would help with debugging what happened from the client side perspective

ElChopChop commented 2 years ago

Thanks for getting back to me - I'm using Umbrel, so would I need to access this LN data through Command Line?

Don't worry if this is too much hassle, I'm really not bothered about the funds just would like to know what's happened before I try more Loop Outs.

alexbosworth commented 2 years ago

I'm not sure where the logs would be kept but yeah I would look for the loop data directory on the disk there, I think Umbrel moves data directories around so I'm not sure where it would be exactly

It would definitely be helpful to know what happened on the client side, I think if you look at the payment request associated with the Loop Out you can also see the output script so you can see the address of the funds committed to on-chain, that should confirm that the Loop service did put the HTLC on chain and at that point it is the responsibility of the client to take the funds. If it does not take the funds then after a timeout they will be taken back to the server and the prepay amount will not be returned.

Wolf-Raider commented 2 years ago

I had the same issure. I startet a loop out. after initiation i got messages like "miner fee X is > loop fee Y". that was because suddently after i startet the loop the bitcoin mempool grows up. after it was down again (16-10h later) i got a "TEMPORARY_CHANNEL_FAILURE" and a message from loop, that is not save to settle the BTC. now i lost 30000sat. (15 dollar) sorry thats to much, in the future i will loop out my self over a lightning wallet. hat is much cheaper and more save.

Wolf-Raider commented 2 years ago

I think i found the bug: 2022-01-26 01:16:34.166 [WRN] LOOP: 774a3c Required fee 0.00000269 BTC exceeds max miner fee of 0.00000148 BTC 2022-01-26 01:16:34.166 [WRN] LOOP: 774a3c Not revealing preimage

At this point the mempool was empty. Some tool (Loop?) calculated there some wrong fees, so the loop could never complete and robbed my preepayment (as penalty)...

carlaKC commented 2 years ago

We have identified the issue with the current max miner value and it has been fixed in LiT v0.6.2-alpha. Other UIs will need to update to this version for the fix to take effect. In the meanwhile, swaps dispatched from the cli are unaffected.

We're also working on a longer term improvement to ensure that we don't run into this.

lxnay commented 2 years ago

I have a similar problem with Payment ID: 0d4a538bfb8fba91475cc53f075a834a95e71b2878d71625faf1b87098dd70d3 Loop out swap id: dbea92ac49e3e3f2c76d0a5b7179acb5150049624abd396f75028a906e6b3638

This loop out has been stuck with the following log below for many days at this point. How do I cancel it or get it unstuck?

022-01-26 13:31:31.319 [INF] LOOP: dbea92 Register 1 conf ntfn for swap script on chain (hh=720079) 2022-01-26 13:31:31.319 [INF] LOOP: dbea92 Checking preimage reveal height 720159 exceeded (height 720477) 2022-01-26 13:31:31.319 [INF] LOOP: dbea92 Max preimage reveal height 720159 exceeded (height 720477) 2022-01-26 13:31:31.319 [INF] LOOP: dbea92 Wait for server pulling off-chain payment(s) 2022-01-26 13:31:31.342 [INF] LOOP: dbea92 Payment 0d4a538bfb8fba91475cc53f075a834a95e71b2878d71625faf1b87098dd70d3: state=IN_FLIGHT, inflight_htlcs=0, inflight_amt=0 mSAT 2022-01-26 13:31:31.357 [INF] LOOP: dbea92 Payment dbea92ac49e3e3f2c76d0a5b7179acb5150049624abd396f75028a906e6b3638: state=IN_FLIGHT, inflight_htlcs=1, inflight_amt=385421500 mSAT 2022-01-26 13:31:31.404 [INF] LOOP: dbea92 Payment 0d4a538bfb8fba91475cc53f075a834a95e71b2878d71625faf1b87098dd70d3: state=IN_FLIGHT, inflight_htlcs=1, inflight_amt=30000000 mSAT 2022-01-26 13:31:32.110 [INF] LOOP: dbea92 Server update: SERVER_FAILED_OFF_CHAIN_TIMEOUT received, timestamp: 2022-01-23 20:25:04.692603575 +0000 UTC 2022-01-26 13:31:32.110 [INF] LOOP: dbea92 swap subscription: server finished serving updates 2022-01-26 13:31:33.422 [INF] LOOP: dbea92 Payment 0d4a538bfb8fba91475cc53f075a834a95e71b2878d71625faf1b87098dd70d3: state=IN_FLIGHT, inflight_htlcs=0, inflight_amt=0 mSAT 2022-01-26 13:31:33.496 [INF] LOOP: dbea92 Payment 0d4a538bfb8fba91475cc53f075a834a95e71b2878d71625faf1b87098dd70d3: state=IN_FLIGHT, inflight_htlcs=1, inflight_amt=30000000 mSAT 2022-01-26 13:31:39.126 [INF] LOOP: dbea92 Payment 0d4a538bfb8fba91475cc53f075a834a95e71b2878d71625faf1b87098dd70d3: state=IN_FLIGHT, inflight_htlcs=0, inflight_amt=0 mSAT 2022-01-26 13:31:39.177 [INF] LOOP: dbea92 Payment 0d4a538bfb8fba91475cc53f075a834a95e71b2878d71625faf1b87098dd70d3: state=IN_FLIGHT, inflight_htlcs=1, inflight_amt=30000000 mSAT 2022-01-26 13:32:00.962 [INF] LOOP: dbea92 Payment 0d4a538bfb8fba91475cc53f075a834a95e71b2878d71625faf1b87098dd70d3: state=IN_FLIGHT, inflight_htlcs=0, inflight_amt=0 mSAT 2022-01-26 13:32:00.983 [INF] LOOP: dbea92 Payment 0d4a538bfb8fba91475cc53f075a834a95e71b2878d71625faf1b87098dd70d3: state=FAILED 2022-01-26 13:32:00.983 [INF] LOOP: dbea92 Prepayment failed: payment failed: FAILURE_REASON_INCORRECT_PAYMENT_DETAILS

masterno12 commented 2 years ago

Same issue here, i paid 30 000 sats for "wind" , do you have an idea for resolving this issue ?

DLux76198 commented 2 years ago

Same thing happened here. I initiated three transactions, all failed, and the prepayment for each was 30k sats.