search

lightninglabs / neutrino

Privacy-Preserving Bitcoin Light Client
MIT License
907 stars 182 forks source link

Add Makefile, use golangci-lint, move to GitHub actions #217

Closed guggero closed 3 years ago

guggero commented 3 years ago

As a new contributor to the Neutrino repository it was a bit of a challenge to figure out how to use the clunky gotest.sh file. That's why I think it would be nice to switch over to a Makefile.

At the same time I felt like we should fix a number of smaller issues that an updated linter should find. That's why I opted to add the golangci-lint linter as well. And I think I might even have discovered a possible explanation for some of the flakes we see in the lnd itests with Neutrino (see 0a824919, could also be mistaken about the significance of this).

guggero commented 3 years ago

It looks like the GitHub actions aren't running yet, is there anything else that needs to be done?

Changes in GH actions in a PR aren't applied until the PR is merged. I think it's a security measure to make sure repository secrets cannot be extracted easily just by opening a PR.

guggero commented 3 years ago

@cfromknecht PTAL

halseth commented 3 years ago

@guggero Feel free to merge when you've checked out whether the comments are actionable

guggero commented 3 years ago

@halseth I rebased and added two more commits. I don't have merge permissions in this repo so feel free to push the button if you think this is ready.