search

lightninglabs / neutrino

Privacy-Preserving Bitcoin Light Client
MIT License
900 stars 183 forks source link

neutrino: increase timeout between inv and getmsg when sending tx #219

Closed hsjoberg closed 3 years ago

hsjoberg commented 3 years ago

The current time of 500ms can be too low if for example the network conditions are poor. This increases the timeout window to 10s which should be sufficient to cover any scenarios.

This has been causing real issues with lnd (and bitcoind) where SendCoins and channel openings wouldn't get broadcasted. https://github.com/lightningnetwork/lnd/issues/5130 https://github.com/hsjoberg/blixt-wallet/issues/278

@wpaulino I've removed your TODO-message which was directly related to this issue, if that's okay with you.

Cheers!

coveralls commented 3 years ago

Coverage Status

Coverage decreased (-0.1%) to 72.237% when pulling 5fadb5569db680e0423682661b8e1e2c4280a964 on hsjoberg:inv-timeout-increase into 5e09bd9b5d65e90c6ff07aa11b3b9d80d42afb86 on lightninglabs:master.

Roasbeef commented 3 years ago

@hsjoberg are you able to reproduce the issue with this increased timeout?

hsjoberg commented 3 years ago

@Roasbeef No, I haven't been able to reproduce the issue with this patch.