search

lightninglabs / neutrino

Privacy-Preserving Bitcoin Light Client
MIT License
900 stars 183 forks source link

set headerfs.BlockStamp.Timestamp #235

Closed chappjc closed 2 years ago

chappjc commented 2 years ago

The headerfs.BlockStamp returned from (*ChainService).BestBlock had a zero Timestamp. This change sets the Timestamp field from the block header if available.

Internally it does not seem to matter that Timestamp is the zero time.Time, but for ChainService consumers it is helpful to have the block's timestamp. For example, one may compare the timestamp from the current best block from ChainService to the wallet Manager's birthday time.

lightninglabs-deploy commented 2 years ago

@chappjc, remember to re-request review from reviewers for your latest update

lightninglabs-deploy commented 2 years ago

@ellemouton: review reminder

lightninglabs-deploy commented 2 years ago

@ellemouton: review reminder

lightninglabs-deploy commented 2 years ago

@ellemouton: review reminder

chappjc commented 2 years ago

:pray: Thanks! This will be a helpful change on our end.