Closed chappjc closed 2 years ago
@chappjc, remember to re-request review from reviewers for your latest update
@ellemouton: review reminder
@ellemouton: review reminder
@ellemouton: review reminder
:pray: Thanks! This will be a helpful change on our end.
The
headerfs.BlockStamp
returned from(*ChainService).BestBlock
had a zeroTimestamp
. This change sets theTimestamp
field from the block header if available.Internally it does not seem to matter that
Timestamp
is the zerotime.Time
, but forChainService
consumers it is helpful to have the block's timestamp. For example, one may compare the timestamp from the current best block fromChainService
to the walletManager
's birthday time.