neutrino: Added unban peer feature

lightninglabs / neutrino

Privacy-Preserving Bitcoin Light Client

MIT License

894 stars 182 forks source link

neutrino: Added unban peer feature #270

Closed Chinwendu20 closed 1 year ago

Chinwendu20 commented 1 year ago

Changes:

Added unbanpeer method to chainservice.
Added unbanipnet method to banstore

Associated PR in LND: https://github.com/lightningnetwork/lnd/pull/7606 (With detailed explanation on how to test with LND) Fixes issue: https://github.com/lightninglabs/neutrino/issues/253

Roasbeef commented 1 year ago

Has a linter error failure:

neutrino.go:1085: unnecessary leading newline (whitespace)
    defer func() {

Chinwendu20 commented 1 year ago

Hello @Roasbeef I have fixed that

Chinwendu20 commented 1 year ago

Okay I would write the test. I can write test for the newly added method in store.go but for the newly added chainservice method. I see that chainservice methods do not have unit tests written for them, there is no neutrino_test.go file.

lightninglabs-deploy commented 1 year ago

@positiveblue: review reminder @chinwendu20, remember to re-request review from reviewers when ready

Chinwendu20 commented 1 year ago

Hello, the commit issues here, I do not know how to fix them, so I would be creating a new PR for this.