Closed Chinwendu20 closed 7 months ago
@Crypt-iQ, this is the PR.
Thank you guys but I am.not sure if this PR is still valid. Since there is no need to reset ranking?
Since there is no need to reset ranking?
What makes you think that? IIUC, the original intent was the a peer's ranking isn't necessarily the same between reconnects (changes in network, implementation, hardware, etc, etc). I'd consider the fact that they were never reset to be a bug.
Since there is no need to reset ranking?
What makes you think that? IIUC, the original intent was the a peer's ranking isn't necessarily the same between reconnects (changes in network, implementation, hardware, etc, etc). I'd consider the fact that they were never reset to be a bug.
Oh okay, this comment: https://github.com/lightninglabs/neutrino/issues/280#issuecomment-1703914567, I was just wondering since work would still be distributed, there would be no need for fetch from that from that particular peer which disconnected.
But I guess the current setup makes for a bug in itself, thanks for pointing it out.
@chinwendu20, remember to re-request review from reviewers when ready
This PR addresses https://github.com/lightninglabs/neutrino/issues/280
Fixes #280