search

lightninglabs / neutrino

Privacy-Preserving Bitcoin Light Client
MIT License
894 stars 182 forks source link

neutrino: Added ResetRanking method to PeerRanking. #288

Closed Chinwendu20 closed 7 months ago

Chinwendu20 commented 11 months ago

This PR addresses https://github.com/lightninglabs/neutrino/issues/280

Fixes #280

Chinwendu20 commented 11 months ago

@Crypt-iQ, this is the PR.

Chinwendu20 commented 8 months ago

Thank you guys but I am.not sure if this PR is still valid. Since there is no need to reset ranking?

Roasbeef commented 8 months ago

Since there is no need to reset ranking?

What makes you think that? IIUC, the original intent was the a peer's ranking isn't necessarily the same between reconnects (changes in network, implementation, hardware, etc, etc). I'd consider the fact that they were never reset to be a bug.

Chinwendu20 commented 8 months ago

Since there is no need to reset ranking?

What makes you think that? IIUC, the original intent was the a peer's ranking isn't necessarily the same between reconnects (changes in network, implementation, hardware, etc, etc). I'd consider the fact that they were never reset to be a bug.

Oh okay, this comment: https://github.com/lightninglabs/neutrino/issues/280#issuecomment-1703914567, I was just wondering since work would still be distributed, there would be no need for fetch from that from that particular peer which disconnected.

But I guess the current setup makes for a bug in itself, thanks for pointing it out.

lightninglabs-deploy commented 7 months ago

@chinwendu20, remember to re-request review from reviewers when ready