Closed djkazic closed 2 months ago
OK, it appears that queryAllPeers
breaks the unit test when the numRetries
of the defaultQueryOptions
struct is > 1.
Cool, so I fixed the unit test.
Now, the Blixt team will do some testing to make sure that we haven't also rolled back the perf improvements.
cool LGTM - before the final ✅ though, can you open an LND PR that points to this so that we can just check the CI on that side?
Created here: https://github.com/lightningnetwork/lnd/pull/8797
cool thanks - will ACK this once the neutrino test on that side is green
@djkazic, remember to re-request review from reviewers when ready
After working with @hsjoberg and @niteshbalusu11 to troubleshoot Blixt performance we realized two things were consistently going wrong in networks with > around 300ms latency:
After investigating, we decided to experiment with changing some constants in neutrino to work better.
This PR addresses both issues by:
The result is that we can now use Blixt with networks that we could not previously.