lightninglabs / pool

Lightning Pool: a non-custodial batched uniform clearing-price auction for Lightning Channel Leases (LCL). An LCL packages up inbound channel liquidity (ability to receive funds) as a fixed income asset with a maturity date expressed in blocks.
MIT License
251 stars 46 forks source link

Ask Orders doesn't settle #478

Open jimmydjabali opened 5 months ago

jimmydjabali commented 5 months ago

Expected behavior After submitted an "Ask" order (Sell channel), it should automatically open a channel to the selected node.

Actual behavior After submitted an "Ask" order (Sell channel), the order is blocked on the "ORDER_SUBMITTED" state for several days, with the following details:

{
    "asks":  [
        {
            "details":  {
                "trader_key":  "XXXXX",
                "rate_fixed":  694,
                "amt":  "10000000",
                "max_batch_fee_rate_sat_per_kw":  "12500",
                "order_nonce":  "XXXXX",
                "state":  "ORDER_SUBMITTED",
                "units":  100,
                "units_unfulfilled":  100,
                "reserved_value_sat":  "10002135",
                "creation_timestamp_ns":  "1707304700838378803",
                "events":  [
                    {
                        "timestamp_ns":  "1707304700838378803",
                        "event_str":  "OrderCreated"
                    }
                ],
                "min_units_match":  100,
                "channel_type":  "ORDER_CHANNEL_TYPE_PEER_DEPENDENT",
                "allowed_node_ids":  [
                    "XXXXX"
                ],
                "not_allowed_node_ids":  [],
                "auction_type":  "AUCTION_TYPE_BTC_INBOUND_LIQUIDITY",
                "is_public":  true
            },
            "lease_duration_blocks":  2016,
            "version":  5,
            "announcement_constraints":  "ANNOUNCEMENT_NO_PREFERENCE",
            "confirmation_constraints":  "CONFIRMATION_NO_PREFERENCE"
        }
    ],
    "bids":  []
}

To reproduce

System information

I'm using Pool as part of Lightning Terminal.

Roasbeef commented 5 months ago

If you do pool getinfo what's your node's tier in node_rating? That needs to be TIER_1 to allow you to submit asks in the "main" market.

After submitted an "Ask" order (Sell channel), it should automatically open a channel to the selected node.

Note that this is a market, you won't automatically have you asked order be filled. Filling an ask order means someone had a corresponding bid order (wanted to buy a channel at the rate you posted).

jimmydjabali commented 5 months ago

@Roasbeef The node is TIER_1.

I didn't posted, but directly matched an offer in the "Sell" tab. So I expect the remote's node is willing/ready to accept new channels