Closed dstadulis closed 1 year ago
It could make sense to divide this into PRs
asset_genesis
and asset_group_key_reveal
to proof file (version >= 1)asset_genesis
and group_key
at initial mint: https://github.com/lightninglabs/taproot-assets/pull/448Worth noting we're planning to not actually bump the proof file version, but yes this SGTM.
Verify asset_genesis and group_key at initial mint.
Picking up this one.
Needs to be split up into individual issues for the next jaunt.
Verify asset_genesis and group_key at initial mint.
Starting this one
Add asset_genesis and asset_group_key_reveal to proof file (version >= 1)
I'm starting this one. @halseth I hope that's not something you're already working on (tracking issue https://github.com/lightninglabs/taproot-assets/issues/441).
@guggero I have started this one:
Verify asset emission against group key (virtual tx state transition)
so make sense for you to take on the proof file 👍
@guggero I have started this one:
Verify asset emission against group key (virtual tx state transition)
so make sense for you to take on the proof file 👍
@halseth would that include populating the witness in the minted asset as well? Thinking of which may not yet have a PR started for implementing them.
@jharveyb If you want to make a PR for populating the witness, feel free to do so! This is a starting point I used just for prototyping it: https://github.com/halseth/taproot-assets/commit/7e8506542545b256614d05c8224a363e3f375ab2#diff-cba29164382adad1ea3c845d266d8fb28e183f1a83e2f8940b23f38d1b608e95R511
However I'm travelling this week, so won't have the chance to make it into a proper PR before next week.
Additional items:
Verify asset emission against group key (virtual tx state transition)
@jharveyb will make a tracking issue for this
New tracking issues for last two tasks are #465 and #466 .
All components are tracked, superceded by #466 and #511 .
Wrapper issue to track https://github.com/Roasbeef/bips/pull/33