To support the changes specified in https://github.com/Roasbeef/bips/pull/33 (more complex group key derivation + reveal genesis and group key information in the minting proof), we need to modify the base Asset and Proof structs to add new fields. This involves also adding encoders & decoders for these fields, and new DB fields for some fields like the revealed tapscript root used to tweak the group key.
We also want to add logic to reject unknown Asset and Proof versions, to prepare for future significant changes to these objects.
This issue does not cover any functionality changes needed to implement https://github.com/Roasbeef/bips/pull/33, just the underlying DB, encode/decode, etc. changes needed to actually start implementing that functionality.
jharveyb
commented
1 year ago
To support the changes specified in https://github.com/Roasbeef/bips/pull/33 (more complex group key derivation + reveal genesis and group key information in the minting proof), we need to modify the base Asset and Proof structs to add new fields. This involves also adding encoders & decoders for these fields, and new DB fields for some fields like the revealed tapscript root used to tweak the group key.
We also want to add logic to reject unknown
AssetandProofversions, to prepare for future significant changes to these objects.This issue does not cover any functionality changes needed to implement https://github.com/Roasbeef/bips/pull/33, just the underlying DB, encode/decode, etc. changes needed to actually start implementing that functionality.
PR: https://github.com/lightninglabs/taproot-assets/pull/381
Marked as size Small because the PR is on round 3 of review and review cycles have been short.