lightninglabs / taproot-assets

A layer 1 daemon, for the Taproot Assets Protocol specification, written in Go (golang)
MIT License
457 stars 110 forks source link

BLIP update: RFQ wire messages #859

Open dstadulis opened 5 months ago

dstadulis commented 5 months ago

845 #683 #792 #778

Cover the RFQ implementations in which some slight updates @ffranr to enumerate those updates in this issue

ffranr commented 5 months ago

The changes I think we should make to RFQ section of the tap BLIP can be found in these reviews that I've left on the tap BLIP PR:

https://github.com/lightning/blips/pull/29#pullrequestreview-1848901112 https://github.com/lightning/blips/pull/29#pullrequestreview-1853954713 https://github.com/lightning/blips/pull/29#pullrequestreview-1856677414 https://github.com/lightning/blips/pull/29#pullrequestreview-1856778322 https://github.com/lightning/blips/pull/29#pullrequestreview-1856784223 https://github.com/lightning/blips/pull/29#pullrequestreview-1856785907


Summary

I'll create PR(s) for the following RFQ section modifications:

Other lower priority modifications:

ffranr commented 1 month ago

Corresponding PR: https://github.com/Roasbeef/blips/pull/4

dstadulis commented 1 month ago

Almost ready can be pulled out of draft soon @ffranr will apply some small changes

ffranr commented 1 day ago

In this issue, we are implementing the following changes:

These changes follow the guidelines outlined in docs/rfq-and-decimal-display.md as detailed here: PR #1059.