Open dstadulis opened 5 months ago
The changes I think we should make to RFQ section of the tap BLIP can be found in these reviews that I've left on the tap BLIP PR:
https://github.com/lightning/blips/pull/29#pullrequestreview-1848901112 https://github.com/lightning/blips/pull/29#pullrequestreview-1853954713 https://github.com/lightning/blips/pull/29#pullrequestreview-1856677414 https://github.com/lightning/blips/pull/29#pullrequestreview-1856778322 https://github.com/lightning/blips/pull/29#pullrequestreview-1856784223 https://github.com/lightning/blips/pull/29#pullrequestreview-1856785907
I'll create PR(s) for the following RFQ section modifications:
suggested_rate_tick
field with BTC amount. (IMO, volume matters in a quote.)Other lower priority modifications:
suggested_rate_tick
) included in the request message. Corresponding PR: https://github.com/Roasbeef/blips/pull/4
Almost ready can be pulled out of draft soon @ffranr will apply some small changes
In this issue, we are implementing the following changes:
transfer_type
field to the quote request message.max_amount
field in the quote request message is replaced by max_transferable_in_asset
.These changes follow the guidelines outlined in docs/rfq-and-decimal-display.md
as detailed here: PR #1059.
845 #683 #792 #778
Cover the RFQ implementations in which some slight updates @ffranr to enumerate those updates in this issue