lightninglabs / taproot-assets

A layer 1 daemon, for the Taproot Assets Protocol specification, written in Go (golang)
MIT License
463 stars 111 forks source link

[feature]: RFQ service registers quote SCID with LND SCID alias manager #887

Closed ffranr closed 5 months ago

ffranr commented 6 months ago

This issue relates to the addition of a Short Channel ID (SCID) alias manager to LND, as discussed in Issue #8199.

Objective

After the above-mentioned issue is merged, our next step will involve updating our code to ensure that the tapd RFQ service registers a custom SCID with LND.

Details

The integration should function as follows:

ffranr commented 6 months ago

Completing this issue might not be necessary in order to get our channel payment PoC working. LND doesn't seem to reject the SCID if we use invoice hop hints. We have an itest that uses hop hints to this effect.

dstadulis commented 6 months ago

this issue might not be possible

did you mean necessary?

dstadulis commented 5 months ago

Should this issue be closed @ffranr ?

ffranr commented 5 months ago

This work was completed as part of the tap channel proof-of-concept. It isn't in main yet. But I think we can close this now as it's included in merging work.