[enhancement] Decide: Refactor `EncodeCustomRecords` RPC or Introduce New Payment-Specific RPCs

lightninglabs / taproot-assets

A layer 1 daemon, for the Taproot Assets Protocol specification, written in Go (golang)

MIT License

464 stars 111 forks source link

[enhancement] Decide: Refactor `EncodeCustomRecords` RPC or Introduce New Payment-Specific RPCs #945

Closed dstadulis closed 2 months ago

dstadulis commented 5 months ago

          I think so, yes. Or maybe not, given that with this it should be pretty easy to do the RPC calls in any language. I guess the question is: how much effort is it for the app devs to call 3 RPCs (buy/sell order, encode records, send payment) with the correct values vs. us threading all the payment and channel flags through some new RPC methods in tapd...

_Originally posted by @guggero in https://github.com/lightninglabs/taproot-assets/pull/919#discussion_r1627047819_

Roasbeef commented 2 months ago

Fixes https://github.com/lightninglabs/taproot-assets/pull/1048