This takes off where #31 and #33 left off. It implements the latest version of lightningnetwork/lightning-rfc#593 (4 bits right now, but I think that's heading to 3 bits for the packet type). At the same time with the way the code is implemented right now, it's a short distance away from lightningnetwork/lightning-rfc#604 if we end up going in that direction (only thing that would change in that case is the new HopData method and the packRealm method).
This PR takes the commits from #33, implements a few bug fixes along the way, and the unifies the external caller API with that of #31. It passes all the tests from #31 as is, but I also plan to port over relevant tests from #33 as they exercise additional end-to-end behavior.
Roasbeef
commented
5 years ago
This takes off where #31 and #33 left off. It implements the latest version of lightningnetwork/lightning-rfc#593 (4 bits right now, but I think that's heading to 3 bits for the packet type). At the same time with the way the code is implemented right now, it's a short distance away from lightningnetwork/lightning-rfc#604 if we end up going in that direction (only thing that would change in that case is the new
HopDatamethod and thepackRealmmethod).This PR takes the commits from #33, implements a few bug fixes along the way, and the unifies the external caller API with that of #31. It passes all the tests from #31 as is, but I also plan to port over relevant tests from #33 as they exercise additional end-to-end behavior.