search

lightningnetwork / lightning-onion

Onion Routed Micropayments for the Lightning Network
MIT License
396 stars 125 forks source link

sphinx: remove unused nodeAddr #58

Open joostjager opened 2 years ago

joostjager commented 1 year ago

Requesting review @Roasbeef

Roasbeef commented 1 year ago

I think this is a sane change, but it does end up breaking the API for all callers. As an intermediate step, we could just remove the internal field? Or is there some other motivation behind this change?

joostjager commented 1 year ago

The goal is to break up the API for all callers, so that the caller code can be simplified as well.