search

lightningnetwork / lnd

Lightning Network Daemon ⚡️
MIT License
7.68k stars 2.08k forks source link

[feature]: Add custom TLV fields to HTLC interceptor #7650

Closed carlaKC closed 2 weeks ago

carlaKC commented 1 year ago

Describe the solution you'd like Add the ability to return custom range TLVs from the HTLCInterceptor API.

LND's HLTCInterceptor API is a powerful tool for folks looking to implement custom code on top on LND. Upgrading its reponses to include custom records increases the flexibility of custom features that can be built with it.

Additional context As described in #7297, this ExtraData will not persisted across restarts so there's a possibility that it is dropped. I think the feature is still useful with some lack of reliability (eg, if you're experimenting with odd features your peers may ignore them anyway), and once update_add_htlc TLVs are persisted then this issue is resolved.

carlaKC commented 1 year ago

Will eventually pick this up myself, but opening now in case anybody's eager to give it a try!

guggero commented 2 weeks ago

Can this be closed now with the latest changes to the HTLC interceptor?

carlaKC commented 2 weeks ago

Can this be closed now with the latest changes to the HTLC interceptor?

Yes 🎉

Gary19751957 commented 2 weeks ago

Do not block any of my assets this has been reported to the fbi

Gary Wayne Rollins

On Fri, Oct 11, 2024, 12:08 PM Carla Kirk-Cohen @.***> wrote:

Can this be closed now with the latest changes to the HTLC interceptor?

Yes 🎉

— Reply to this email directly, view it on GitHub https://github.com/lightningnetwork/lnd/issues/7650#issuecomment-2407717927, or unsubscribe https://github.com/notifications/unsubscribe-auth/A6KA5FSDH6GYXIK72FKNAUDZ27ZWPAVCNFSM6AAAAABPZGJGJ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBXG4YTOOJSG4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>