add inbound fees channel updates to notifications

[bufo24]

Adds inbound fees to notifications, used in the SubscribeChannelGraph

[coderabbitai[bot]]

[!IMPORTANT]

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

[bufo24]

I got it working, and noticed that here inbound fees are also not added, is this needed?

[Roasbeef]

Tests don't build:

Error: routing/notifications_test.go:90:3: unknown field InboundFeeBaseMSat in struct literal of type models.ChannelEdgePolicy
Error: routing/notifications_test.go:91:3: unknown field InboundFeePPM in struct literal of type models.ChannelEdgePolicy
Error: routing/notifications_test.go:516:17: edgeUpdate.InboundBaseFee undefined (type *ChannelEdgeUpdate has no field or method InboundBaseFee)
Error: routing/notifications_test.go:516:43: edgeAnn.InboundFeeBaseMSat undefined (type *models.ChannelEdgePolicy has no field or method InboundFeeBaseMSat)
Error: routing/notifications_test.go:519:13: edgeAnn.InboundFeeBaseMSat undefined (type *models.ChannelEdgePolicy has no field or method InboundFeeBaseMSat)
Error: routing/notifications_test.go:520:16: edgeUpdate.InboundBaseFee undefined (type *ChannelEdgeUpdate has no field or method InboundBaseFee)
Error: routing/notifications_test.go:522:17: edgeUpdate.InboundFeeRate undefined (type *ChannelEdgeUpdate has no field or method InboundFeeRate)
Error: routing/notifications_test.go:522:43: edgeAnn.InboundFeePPM undefined (type *models.ChannelEdgePolicy has no field or method InboundFeePPM)
Error: routing/notifications_test.go:524:36: edgeAnn.InboundFeePPM undefined (type *models.ChannelEdgePolicy has no field or method InboundFeePPM)
Error: routing/notifications_test.go:525:16: edgeUpdate.InboundFeeRate undefined (type *ChannelEdgeUpdate has no field or method InboundFeeRate)
Error: routing/notifications_test.go:525:16: too many errors

The linter is also failing:

TimeLockDelta:           uint32(channelUpdate.TimeLockDelta),
rpcserver.go:6711: line is 86 characters (lll)
                MinHtlc:                 int64(channelUpdate.MinHTLC),
rpcserver.go:6712: line is 87 characters (lll)
                MaxHtlcMsat:             uint64(channelUpdate.MaxHTLC),
rpcserver.go:6713: line is 86 characters (lll)
                FeeBaseMsat:             int64(channelUpdate.BaseFee),
rpcserver.go:6714: line is 86 characters (lll)
                FeeRateMilliMsat:        int64(channelUpdate.FeeRate),
routing/notifications_test.go:5[31](https://github.com/lightningnetwork/lnd/actions/runs/8974797777/job/24647950244?pr=8723#step:7:32): multi-line statement should be followed by a newline (whitespace)
            edgeUpdate.ExtraOpaqueData, edgeAnn.ExtraOpaqueData) {

[bufo24]

Those tests cases should be resolved in my latest commit. I am not super familiar with Go, what's the best way to resolve these long lines? Which causes the linter to fail

[bufo24]

Lint issues resolved and release notes updated. Some integration tests are failing, but are not related to my changes it seems 🤔