Closed bufo24 closed 3 months ago
[!IMPORTANT]
Auto Review Skipped
Auto reviews are disabled on this repository.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
I got it working, and noticed that here inbound fees are also not added, is this needed?
Tests don't build:
Error: routing/notifications_test.go:90:3: unknown field InboundFeeBaseMSat in struct literal of type models.ChannelEdgePolicy
Error: routing/notifications_test.go:91:3: unknown field InboundFeePPM in struct literal of type models.ChannelEdgePolicy
Error: routing/notifications_test.go:516:17: edgeUpdate.InboundBaseFee undefined (type *ChannelEdgeUpdate has no field or method InboundBaseFee)
Error: routing/notifications_test.go:516:43: edgeAnn.InboundFeeBaseMSat undefined (type *models.ChannelEdgePolicy has no field or method InboundFeeBaseMSat)
Error: routing/notifications_test.go:519:13: edgeAnn.InboundFeeBaseMSat undefined (type *models.ChannelEdgePolicy has no field or method InboundFeeBaseMSat)
Error: routing/notifications_test.go:520:16: edgeUpdate.InboundBaseFee undefined (type *ChannelEdgeUpdate has no field or method InboundBaseFee)
Error: routing/notifications_test.go:522:17: edgeUpdate.InboundFeeRate undefined (type *ChannelEdgeUpdate has no field or method InboundFeeRate)
Error: routing/notifications_test.go:522:43: edgeAnn.InboundFeePPM undefined (type *models.ChannelEdgePolicy has no field or method InboundFeePPM)
Error: routing/notifications_test.go:524:36: edgeAnn.InboundFeePPM undefined (type *models.ChannelEdgePolicy has no field or method InboundFeePPM)
Error: routing/notifications_test.go:525:16: edgeUpdate.InboundFeeRate undefined (type *ChannelEdgeUpdate has no field or method InboundFeeRate)
Error: routing/notifications_test.go:525:16: too many errors
The linter is also failing:
TimeLockDelta: uint32(channelUpdate.TimeLockDelta),
rpcserver.go:6711: line is 86 characters (lll)
MinHtlc: int64(channelUpdate.MinHTLC),
rpcserver.go:6712: line is 87 characters (lll)
MaxHtlcMsat: uint64(channelUpdate.MaxHTLC),
rpcserver.go:6713: line is 86 characters (lll)
FeeBaseMsat: int64(channelUpdate.BaseFee),
rpcserver.go:6714: line is 86 characters (lll)
FeeRateMilliMsat: int64(channelUpdate.FeeRate),
routing/notifications_test.go:5[31](https://github.com/lightningnetwork/lnd/actions/runs/8974797777/job/24647950244?pr=8723#step:7:32): multi-line statement should be followed by a newline (whitespace)
edgeUpdate.ExtraOpaqueData, edgeAnn.ExtraOpaqueData) {
Those tests cases should be resolved in my latest commit. I am not super familiar with Go, what's the best way to resolve these long lines? Which causes the linter to fail
Lint issues resolved and release notes updated. Some integration tests are failing, but are not related to my changes it seems 🤔
Adds inbound fees to notifications, used in the
SubscribeChannelGraph