Closed Chinwendu20 closed 4 months ago
[!IMPORTANT]
Auto Review Skipped
Auto reviews are disabled on this repository.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Does this need a release note? could not find anything about fn
in the other release notes.
Are you aware of this package: https://pkg.go.dev/golang.org/x/exp/maps? Most of what you've added is already here.
Are you aware of this package: https://pkg.go.dev/golang.org/x/exp/maps? Most of what you've added is already here.
Not really, I just checked it and it seems that is that is the case. Thanks for pointing it out would be closing this now.
Thanks for the feedback @ProofOfKeags. I would rework and open another PR. Oops just looked down while typing this and realised that I can reopen this PR.
Thanks.
Do I have to wait for a new release of this package to use it?
Looked at the comments on my tlv PR and it seems like I would just wait. I think maintainers are the ones to make releases.
I pushed a new tag called fn/v1.0.6
. So in the PR that depends on it, you can update the github.com/lightningnetwork/lnd/fn
dependency to v1.0.6
in go.mod
.
Change Description
This adds new functions to the fn packages. Changes include:
This is required for this PR: https://github.com/lightningnetwork/lnd/pull/8516/
Steps to Test
Steps for reviewers to follow to test the change.
Pull Request Checklist
Testing
Code Style and Documentation
[skip ci]
in the commit message for small changes.📝 Please see our Contribution Guidelines for further guidance.