Closed feelancer21 closed 2 months ago
[!IMPORTANT]
Review skipped
Auto reviews are limited to specific labels.
Labels to auto review (1)
* llm-reviewPlease check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
@ellemouton @guggero: Thanks for the fast review. I have added all your comments to the code.
@feelancer21 - I dont think all the comments were addressed (referring to the s/feerate/fee rate comments)
Sorry, my brain read "s/fee/feerate/" and skipped it. Is added now.
Great. Yes, the dependency to walletrpc was the reason to make it a subcommand for lncli wallet
.
@feelancer21, remember to re-request review from reviewers when ready
rebased for 0.18.1
@feelancer21 - could you rebase onto latest master pls?
@ellemouton done
lncli wallet estimatefee
returns the fee estimation of the onchain backend to achieve a given confirmation target.fixes #8726