Closed ellemouton closed 1 month ago
[!IMPORTANT]
Review skipped
Auto reviews are limited to specific labels.
Labels to auto review (1)
* llm-reviewPlease check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
cc: @calvinrzachman for review
note to self: need to add new feature bit to the invoice here
EDIT: done
@ellemouton, remember to re-request review from reviewers when ready
latest push includes dummy hops :) Ready for a look!
Note: quite a bit of the commits are just refactors & set-up
Tracking Issue: https://github.com/lightningnetwork/lnd/issues/6690
Depends on https://github.com/lightningnetwork/lightning-onion/pull/63
High level overview:
This PR is the first in a set of 3 PRs that will implement route blinding receive logic in LND. As LND does not yet support blot 12 invoices, this PR adds them to the Bolt11 invoice serialisation.
With this PR, a user can request that a bolt 11 invoice include blinded paths and will also be able to pay to a bolt 11 invoice that includes blinded paths. However, with this PR, only one of the paths in the invoice will be used. A follow up PR will add the ability to make use of multiple paths.
UPDATE: This has been updated to include dummy hop padding :)
Lower level overview: