Closed orbitalturtle closed 2 months ago
[!IMPORTANT]
Auto Review Skipped
Auto reviews are disabled on this repository.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Also just want to check offline with some folks to check if perhaps a better move would be to add an experimental build tag instead. Will get back to you here about the response.
Ideally, these should be enabled in the default build to make these more accessible.
It would be amazing to get this into 0.18 to enable people to leverage these features without needing to create custom builds with special tags enabled. That would help further adoption of bolt 12 through lndk.
cc @saubyk
Trying to understand the need for this push given we are so close to wrapping up 0.18. Assuming we have sophisticated users for LNDK, why can’t they do custom build with make install and the tag? Is it because it's a "dev" tag that it appears problematic?
Trying to understand the need for this push given we are so close to wrapping up 0.18. Assuming we have sophisticated users for LNDK, why can’t they do custom build with make install and the tag?
I understand your concern about the timing of this push for 0.18. While LNDK users may tend to be technically proficient right now (partially because they need to be due to the current barriers to entry, like this one), Interest in Bolt 12 extends beyond advanced users, and LNDK is currently the primary path for enabling partial adoption for the vast majority of Lightning Network users who rely on LND.
I'd summarise as:
Reduced Barrier to Entry: Currently, using these features requires compiling LND with a specific tag, a hurdle for anyone new to the system. By including it in the main configuration, users of all technical backgrounds can simply download the latest LND release (or use the official Lightning Labs Docker image, or spin up a setup using Polar) and install and connect LNDK. Removing the need for custom builds, custom docker images, and enabling more easy integration with tools like Polar would lower the barrier to entry and encourages wider adoption.
Potential Future Integration: Including these options in the main configuration lays the groundwork for future feature integration. This could lead to a more streamlined process for utilizing advanced functionalities in the future, benefiting both new and experienced users.
Early Feedback and Informed Development: Including these features now allows us to gather valuable user feedback and inform future development decisions related to Bolt 12 and LNDK integration. This can help ensure these features meet the needs of the broader user base.
While the 0.18 release cycle is nearing completion, the benefits of broader accessibility, smoother user experience, and early user feedback may make including this change now make sense. It could significantly help to boost adoption and encourage more people to explore these features.
Is it because that it's a "dev" tag that it appears problematic?
That is a problem. The dev
tag is intended to be used for development builds. Many people would not want to run development builds in production, but would want to use this specific feature.
Tagged for 0.18. Gated on @carlaKC 's review
Change Description
This PR simply moves the experimental custom message config options to the main protocol config, so that the dev build flag doesn't need to be set to use them. Closes issue #8536.
We've gotten multiple requests for this at LNDK -- people don't want to be running LND in dev mode in production. There hasn't been any discussion on the #8536 issue, so hoping to at least spur discussion on what needs to happen to make this change feasible. :)
Tested this with LNDK to confirm it works properly.
Steps to Test
The config options set in
sample-lnd.conf
should be possible to set without the dev flag.