Open ziggie1984 opened 2 months ago
[!IMPORTANT]
Auto Review Skipped
Auto reviews are disabled on this repository.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Let's see whether all the unit tests pass using the global kvdb backend tag
Short summary of the current PR:
The current set of unit tests are not easily portable to all available backends. We are currently running a lot of tests on the boltdb backend, switching over to the global kvdb_architecture flag (e.g. kvdb_etcd ...) needs still work to be done. For example the copy of the db file needs to be different for all backends, we cannot just copy a file like in boltdb in the etcd case. Moreover postgres seems to have problems handling the workload while running embedded (but not sure, this needs to be investigated too).
@bhandras proposed taking over this issue because he is already very knowledge in this code area.
@ziggie1984, remember to re-request review from reviewers when ready
Replaces #8462
This PR fixes a testcase where we would basically test not what the testcase was suppose to test (reopening the same database).
Moreover it enhances a lot of unit-tests which would initially only test the bolt db backend and makes those tests compatible with the global kvdb backend, so those tests are now executed depending on the selected golang kv tag.