Closed yyforyongyu closed 4 months ago
[!IMPORTANT]
Auto Review Skipped
Auto reviews are disabled on this repository.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
@morehouse Yeah the itest failure is annoying, don't think it can be properly fixed until blockbeat
is in. Here's some logs which show that the subsystems have very different views of block heights,
2024-05-18 04:24:15.394 [DBG] SWPR: Received new block: height=476, attempt sweeping 0 inputs
...
2024-05-18 04:24:15.418 [INF] CNCT: *contractcourt.htlcSuccessResolver(ee04c77ad329073b6b7e1899e0173aa6c1835727f647b0853099fc7dcc6e0d2b): offering second-level success tx output to sweeper with no deadline and budget=0.00050000 BTC at height=471
...
2024-05-18 04:24:15.418 [INF] SWPR: Sweep request received: out_point=e0749b9458c5f6693eb79b6a6293feb44435467b2a68680185921f0d86425805:0, witness_type=HtlcAcceptedSuccessSecondLevel, relative_time_lock=4, absolute_time_lock=0, amount=0.00100000 BTC, parent=(<nil>), params=(startingFeeRate={false 0}, immediate=false, exclusive_group=none, budget=0.00050000 BTC, deadline=none)
2024-05-18 04:24:15.418 [INF] CNCT: *contractcourt.htlcSuccessResolver(ee04c77ad329073b6b7e1899e0173aa6c1835727f647b0853099fc7dcc6e0d2b): waiting for second-level HTLC output to be spent after csv_delay=4
...
2024-05-18 04:24:15.418 [DBG] SWPR: TxPublisher received new block: 471
As for now, I did an extra check in the test to make it pass. More work to do in 18.1, as I wanna fix these multi-hop tests so it's easier to maintain in the future.
Fixes #8741 Fixes #8738
TODO: