Open ziggie1984 opened 4 months ago
[!IMPORTANT]
Review Skipped
Auto reviews are disabled on this repository.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
@Crypt-iQ could you take a look and evaluate if this is the right direction I am going, it relates to the atomic deletion of the option-scid channels also discussed here(https://github.com/lightningnetwork/lnd/pull/7759#discussion_r1344346308)
Thank you in advance 🙏
@Crypt-iQ could you take a look and evaluate if this is the right direction I am going, it relates to the atomic deletion of the option-scid channels also discussed here(#7759 (comment))
Thank you in advance 🙏
Yes this approach looks good
When the option SCID is used we need to make sure we update the channel data in an atomic way so that we don't miss any updates by our peer because we rate limit ChanUpdate msg which can cause some side effects revealed in https://github.com/lightningnetwork/lnd/pull/8582
Prerequisite for: https://github.com/lightningnetwork/lnd/pull/8582