Closed Roasbeef closed 1 month ago
[!IMPORTANT]
Review skipped
Auto reviews are limited to specific labels.
Labels to auto review (1)
* llm-reviewPlease check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Stats of the last 30 days for lnd: | User | Total reviews | Time to review | Total comments | |
---|---|---|---|---|---|
guggero 🥇 |
15 ▀▀ |
12h 36m)) |
13 ▀ |
||
ellemouton 🥈 |
11 ▀ |
2d 13h 15m)) |
27 ▀▀ |
||
yyforyongyu 🥉 |
10 ▀ |
4d 12h 39m)) ▀ |
30 ▀▀ |
||
bhandras |
7 ▀ |
15m)) |
6 |
||
Roasbeef |
6 ▀ |
2d 1h 38m)) |
18 ▀ |
||
ProofOfKeags |
5 ▀ |
2d 12h 16m)) |
20 ▀ |
||
bitromortac |
5 ▀ |
5d 19h 18m)) ▀ |
29 ▀▀ |
||
saubyk |
4 ▀ |
8h 30m)) |
1 |
||
morehouse |
2 |
1d 21h 2m)) |
11 ▀ |
||
Abdulkbk |
2 |
3d 19h 35m)) ▀ |
0 |
||
ffranr |
1 |
2h 16m)) |
1 |
||
sputn1ck |
1 |
46m)) |
1 |
||
Crypt-iQ |
1 |
5d 2m)) ▀ |
1 |
||
Tguntenaar |
1 |
10d 23h 10m)) ▀▀ |
0 |
||
carlaKC |
1 |
6d 22h 48m)) ▀ |
1 |
||
Chinwendu20 |
1 |
5d 15h 48m)) ▀ |
5 |
||
ziggie1984 |
1 |
2d 23h 19m)) ▀ |
10 ▀ |
In this PR, we add a new interface, the
AuxChanCloser
. This interfaces allows a caller wrappinglnd
in another Go program (not exposed over RPC for now) to add additional outputs to a co-op close transaction, and also modify the way sorting happens with the co-op close transaction.We handle the extra close outputs by deducting the value of a party's output from their normal settled output. If after that deduction, their output is dust, then we'll just swap out the old delivery addr script with this new addr. If a party doesn't have an output on the coop close transaction, then they can't add a new output.
Along the way, I've re-introduced a result type (
Result[T]
) as it makes it easier to write idiomatic Go code when using option return values. It also makes a limited version of Railway Oriented Programming possible.Note to reviewers: I added some commits in the
tlv
package that seemed to be missing from the current integration branch.