Closed ellemouton closed 3 months ago
[!IMPORTANT]
Review skipped
Auto reviews are limited to specific labels.
Labels to auto review (1)
* llm-reviewPlease check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
@yyforyongyu: review reminder
Tested with the test setup described in https://github.com/lightningnetwork/lnd/issues/8785, it fixes the issue.
awesome - thanks for testing @JssDWt 🚀
In this PR, we start assuming that hops on a path all support TLV onion encoding.
This PR is the bare minimum. It does not completely remove the
Hop.LegacyPayload
member since we do still use this for deserialising persisted Hops for an HTLC attempt. So there is a chance that we have some on disk. And since we do have cases where we assume hops only support legacy encoding (either we did not receive their node announcement or we received chained hop hints in an invoice) the chances of this being the case are not that small. So some discussion/thought is perhaps needed around how we can handle this.The other thing we could potentially add to this PR is the removal of
--protocol.legacy.onion
We already no longer read the
TlvPayload
boolean inSendToRouteReq.Hop
so we could potentially remove this or warn the user if they are setting this tofalse
that it is being ignored.Fixes: https://github.com/lightningnetwork/lnd/issues/8785