lightningnetwork / lnd

Lightning Network Daemon ⚡️
MIT License
7.55k stars 2.06k forks source link

build: enable coveralls as a required check #8846

Open Roasbeef opened 2 weeks ago

Roasbeef commented 2 weeks ago

As discussed previously offline, we should make coveralls a required check, as we're now able to have coverage in itests count towards overall coverage. This change is relatively straight forward, as it's a config setting.

Before we do this, we should do a sweep for low hanging fruits to increase code coverage across the board. Eg: many packages are brought down by the fact that we don't call all the functions in log.go. Certain Go quirks re if err != ni also cause the true coverage percentage to be lower than it actually is.

We should also update our contributor guidelines to reflect the org/repo changes.