Open ellemouton opened 2 weeks ago
[!IMPORTANT]
Review skipped
Auto reviews are limited to specific labels.
Labels to auto review (1)
* llm-reviewPlease check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
cc @calvinrzachman
Thanks for the review @Roasbeef 🚀 Squashed in the latest approach - this is ready for another look 👍
@yyforyongyu: review reminder @ellemouton, remember to re-request review from reviewers when ready
This PR achieves 2 goals:
1) Moves graph building and maintaining responsibilities from the
ChannelRouter
to the newgraph.Builder
. These responsibilities include:2) Removes the
ChannelRouter
's direct access to thechanneldb.ChannelGraph
pointer and replace it with an interface instead. This will open up the possibility of providing various other types of graph backends.This chips away at the first few steps noted in issue #8833 and also takes a step towards #8835 since with this PR, the ChannelRouter now only does path finding and payments.
This change is![Reviewable](https://reviewable.io/review_button.svg)