search

lightningnetwork / lnd

Lightning Network Daemon ⚡️
MIT License
7.55k stars 2.06k forks source link

Fixing the current state update when lncli debuglevel and lncli setmccfg are called #8857

Open MPins opened 1 week ago

MPins commented 1 week ago

Fixes #8793

modified: rpcserver.go modified: server.go modified: routing/missioncontrol.go

Change Description

Changed the DebugLevel function to start updating the main cfg DebugLevel variable.

Created the function UpdateEstimatorValue to just update the main cfg estimator value, this function is a callback function when we call NewMissionControl when creating a new server on server.go. And finally, call the callback function on SetConfig on routing/missioncontrol.go

IMPORTANT the estimator value part is not working, for sure I missed something !!! Any Help is welcome !!!

Steps to Test

After running LND with the wallet unlcoked, send the lncli commands to change the debuglevel and estimator and check if they are updated unsing 'getdebuginfo'.

Pull Request Checklist

Testing

Code Style and Documentation

📝 Please see our Contribution Guidelines for further guidance.

coderabbitai[bot] commented 1 week ago

[!IMPORTANT]

Review skipped

Auto reviews are limited to specific labels.

Labels to auto review (1) * llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
Abdulkbk commented 1 week ago

Nice work @MPins. I left a few comments.

Also, I don't think this commit is necessary since all you did was add comments.

MPins commented 1 week ago

Nice work @MPins. I left a few comments.

Also, I don't think this commit is necessary since all you did was add comments

Thank you! ... About this last comment ... That's weird ... because I've added the line containing 'cfg.UpdateEstimatorValue(cfg.Estimator)' also

MPins commented 5 days ago

Hello everyone, the code is working as expected! But the changes made with lncli setmccfg are not impacting the information we get from lncli getdebuginfo . It looks like the GetDebugInfo function is getting this information from somewhere else. https://github.com/lightningnetwork/lnd/blob/71ba355d903f01990718866c358c2ccac9402891/rpcserver.go#L3164

Chinwendu20 commented 2 days ago

~So GetDebugInfo is getting its info from a different config from the one that you are updating (r.cfg) https://github.com/lightningnetwork/lnd/blob/b67af4a7061f5d14e0f537b8073afa3101d8d16b/rpcserver.go#L3166

You would have to change it to r.server.cfg to get the updated one.

Then maybe change this from r.cfg.LogWriter to r.server.cfg.LogWriter so that all the config updates can be in one place: https://github.com/lightningnetwork/lnd/blob/b67af4a7061f5d14e0f537b8073afa3101d8d16b/rpcserver.go#L6901

I think maybe the config field in the rpcserver struct should be removed entirely since we can access config from the server field but I would like hear what other ppl think about it~

Edit: Please ignore my earlier comments on this, it should work either ways if you are using r.cfg or r.server.cfg as they have same memory address. I think once you fix the pointer thing here it should work https://github.com/lightningnetwork/lnd/pull/8857#discussion_r1663641513