[meta]: Consider increasing column limit

lightningnetwork / lnd

Lightning Network Daemon ⚡️

MIT License

7.69k stars 2.08k forks source link

[meta]: Consider increasing column limit #8877

Open carlaKC opened 4 months ago

carlaKC commented 4 months ago

Opening up for ~chaos~ discussion.

Proposal:

Update column wrapping from 80 -> 100 or 120
Update linter to apply new rules after a set commit

Motivation:

Introduction of generics makes the 80 column limit a lot tighter
Adding nolint:lll everywhere is annoying

Crypt-iQ commented 4 months ago

NACK. 80 is very nice for my laptop screen as it lets me split screen and see all of the columns on both panels. Also, a lot of the cases of nolint:lll can be fixed with either more creative variable naming or extracting out to a function to cut down on verbosity. I also don't want lnd to become like some other unnamed projects that have mega-lines where it looks like you're reading a book.