Beat [0/4]: improve itest miner

yyforyongyu commented 3 weeks ago

This PR refactors the mining methods to make them easier to use. In specific,

Strictly defined MineBlocks, MineEmptyBlocks and MineBlocksAndAssertNumTxes methods, and instructions on how to use them are now shown in the returned error message.
Downgrade HarnessMiner to be a private instance, as previously we've seen a mixed usage of ht.MineBlocksAndAssertNumTxes(1, 1) and ht.Miner.MineBlocksAndAssertNumTxes(1, 1), causing confusion for devs. All the miner-related methods are now moved into a single file, and can only be accessed via ht.
Start tracking the best height in ht and it can be accessed via ht.CurrentHeight(), which is helpful in tests that heavily rely on the block height, e.g., the multi-hop tests.

coderabbitai[bot] commented 3 weeks ago

[!IMPORTANT]

Review skipped

Auto reviews are limited to specific labels.

Labels to auto review (1)
* llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

yyforyongyu commented 2 weeks ago

~~Shuffled the test cases to validate an assumption, let's see how it goes.~~

yyforyongyu commented 1 week ago

We now are seeing two failed tests,

The first happens in bitcoind-postgres, which gives a new error I've never seen before,

2024-07-18 01:48:45.890 UTC [1186] LOG:  unexpected EOF on client connection with an open transaction
2024-07-18 01:48:45.890 UTC [1161] LOG:  unexpected EOF on client connection with an open transaction
2024-07-18 01:48:45.892 UTC [1197] LOG:  unexpected EOF on client connection with an open transaction
    harness_rpc.go:97: 
            Error Trace:    /home/runner/work/lnd/lnd/lntest/rpc/harness_rpc.go:97
                                        /home/runner/work/lnd/lnd/lntest/rpc/lnd.go:84
                                        /home/runner/work/lnd/lnd/lntest/harness_assertion.go:50
                                        /home/runner/work/lnd/lnd/lntest/wait/wait.go:51
                                        /home/runner/work/lnd/lnd/lntest/wait/wait.go:27
                                        /opt/hostedtoolcache/go/1.22.3/x64/src/runtime/asm_amd64.s:1695
            Error:          Received unexpected error:
                            rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing: dial tcp 127.0.0.1:10198: connect: connection refused"
            Messages:       Bob: failed to call GetInfo

Will check the logs and create an issue page to track it.

The second is in neutrino, which is exactly what the blockbeat aims to fix - we get this error because the blocks are not synced, causing one sweeping tx happens before another, while they are supposed to happen in the same block.

lnd_channel_force_close_test.go:743: 
            Error Trace:    /home/runner/work/lnd/lnd/itest/lnd_channel_force_close_test.go:743
                                        /home/runner/work/lnd/lnd/itest/lnd_channel_force_close_test.go:84
            Error:          "[0xc0011da8a0]" should have 6 item(s), but has 1
            Test:           TestLightningNetworkDaemon/tranche02/53-of-156/neutrino/channel_force_closure/committype=SIMPLE_TAPROOT
            Messages:       htlc transaction has wrong num of inputs
    harness.go:440: finished test: channel_force_closure, start height=689, end height=785, mined blocks=96
    harness.go:446: test failed, skipped cleanup

guggero commented 1 week ago

For the postgres one, seems like Bob isn't starting up anymore because it's crashing:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0x65b0b2]

goroutine 3685 [running]:
github.com/btcsuite/btcd/wire.(*MsgTx).Copy(0xc00270f1c0)
    /home/runner/go/pkg/mod/github.com/btcsuite/btcd@v0.24.2-beta.rc1.0.20240625142744-cc26860b4026/wire/msgtx.go:455 +0x512
github.com/lightninglabs/neutrino/pushtx.(*Broadcaster).broadcastHandler.func1()
    /home/runner/go/pkg/mod/github.com/lightninglabs/neutrino@v0.16.1-0.20240425105051-602843d34ffd/pushtx/broadcaster.go:160 +0xf0
github.com/lightninglabs/neutrino/pushtx.(*Broadcaster).broadcastHandler(0xc0006084e0, 0xc001a5ee90)
    /home/runner/go/pkg/mod/github.com/lightninglabs/neutrino@v0.16.1-0.20240425105051-602843d34ffd/pushtx/broadcaster.go:211 +0x2e6
created by github.com/lightninglabs/neutrino/pushtx.(*Broadcaster).Start.func1 in goroutine 2611
    /home/runner/go/pkg/mod/github.com/lightninglabs/neutrino@v0.16.1-0.20240425105051-602843d34ffd/pushtx/broadcaster.go:109 +0xfd

guggero commented 4 days ago

Moooar green CI :heart: The remaining unit test failure (send coverage) will be fixed by https://github.com/lightningnetwork/lnd/pull/8927.

lightningnetwork / lnd

Beat [0/4]: improve itest miner #8892

Review skipped