Closed ziggie1984 closed 1 day ago
[!IMPORTANT]
Review skipped
Auto reviews are limited to specific labels.
Labels to auto review (1)
* llm-reviewPlease check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Let me know if I should remove the lncli
refactor, but I thought we should use the sync call there as well when the incentive is to open a channel in a non-blocking way. Otherwise the for loop on the LND server is still running although the client already exited after receiving the PendingOpenRequest
. So it is a slight improvement because the server side will only cancel the goroutine when the Channel is open (has the required confirmations).
So this PR needs to remove the lncli
change in its own PR apart from this, everything should be ready to go.
Moved the lncli
improvement to https://github.com/lightningnetwork/lnd/pull/8934
Simple fix, though the underlying design probably needs some refactor because even for the batchopen flow we don't really need to do the fee-calculation for every channel but rather for the whole request.
Fixes https://github.com/lightningnetwork/lnd/issues/8895
Will add release-notes as soon as we decided in which release this will be included.