Open mohamedawnallah opened 3 months ago
[!IMPORTANT]
Review skipped
Auto reviews are limited to specific labels.
Labels to auto review (1)
* llm-reviewPlease check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
hey @mohamedawnallah , take a look at my PR here which adds namespaces to the mission control store
Perhaps this PR can be adapted to build on that one since it looks like you are wanting to persist the Pairs from Import
separately to the pairs generated by LND. So the namespaceing PR will make that part easier. Then all that is left to add the option to merge the in-memory MissionControl state so that a we can basically merge the the results of 2 or more namespaces & query results from that
@mohamedawnallah, remember to re-request review from reviewers when ready
@mohamedawnallah - note that https://github.com/lightningnetwork/lnd/pull/9001 has been merged (see previous comment about what that means for the next steps in this PR)
Change Description
Closes #8849
Pull Request Checklist
Testing
Code Style and Documentation
[skip ci]
in the commit message for small changes.📝 Please see our Contribution Guidelines for further guidance.