search

lightningnetwork / lnd

Lightning Network Daemon ⚡️
MIT License
7.65k stars 2.07k forks source link

[feature]: change `openchannel` to make private channels by default #9157

Open AndySchroder opened 6 hours ago

AndySchroder commented 6 hours ago

I believe that the openchannel command should make private channels by default.

With the addition of blinded paths, I think there are a lot of nodes that won't want to announce their channel peers and one should need to make an explicit choice by default to announce channels publicly.

Of course, there should be an option in lnd.conf to change this default, but I believe that default value should be set to private by default. The autopilot feature already has this (https://github.com/lightningnetwork/lnd/blob/9f0cc159ea04edda9f101a35693b8432a31854e1/sample-lnd.conf#L882).

Also, if we get some protocol changes and https://github.com/lightningnetwork/lnd/issues/7902 gets fixed, you could change your mind later if you want to make it public, giving a lot more flexibility to evaluate if the channel partner is a good one before announcing it (it is never going to be possible to make a protocol change to turn a public channel private). Do dynamic commitments help with making https://github.com/lightningnetwork/lnd/issues/7902 possible?

saubyk commented 5 hours ago

Shouldn't this be a prerogative of the applications instead? LND has many types of users ranging from routing nodes to wallets to payment processors to exchanges. This might be preference for one cohort (wallets?), but the rest may not want it as default.