lightningnetwork / lnd

Lightning Network Daemon ⚡️
MIT License
7.72k stars 2.09k forks source link

[bug]: clean up Python gRPC client instructions #9285

Open ZZiigguurraatt opened 6 days ago

ZZiigguurraatt commented 6 days ago

There are some things in the Python gRPC client instructions that were never needed or are no longer needed.

On lines https://github.com/lightningnetwork/lnd/blob/e6efa2e438d8ae151b6df6ce7aa26873c3b990e1/docs/grpc/python.md?plain=1#L20-L24 grpcio googleapis-common-protos mypy-protobuf

can be removed. grpcio is automatically installed by grpcio-tools and googleapis-common-protos is not actually needed because google/api/annotations.proto is not actually needed by the Python gRPC client. As mentioned below, --mypy_out=. does not seem to be actually needed, so that removes the need for mypy-protobuf.

Lines https://github.com/lightningnetwork/lnd/blob/e6efa2e438d8ae151b6df6ce7aa26873c3b990e1/docs/grpc/python.md?plain=1#L25-L29

can be deleted.

On lines

https://github.com/lightningnetwork/lnd/blob/e1df8e9161d070e8b6b362fe13f637b2d92ae750/docs/grpc/python.md?plain=1#L38

and

https://github.com/lightningnetwork/lnd/blob/e1df8e9161d070e8b6b362fe13f637b2d92ae750/docs/grpc/python.md?plain=1#L56

--proto_path=googleapis:. can be replaced with --proto_path=.

.

I'm also not sure what --mypy_out=. is for on lines

https://github.com/lightningnetwork/lnd/blob/e1df8e9161d070e8b6b362fe13f637b2d92ae750/docs/grpc/python.md?plain=1#L38

and

https://github.com/lightningnetwork/lnd/blob/e1df8e9161d070e8b6b362fe13f637b2d92ae750/docs/grpc/python.md?plain=1#L56

It also does not seem to be needed

Also, I'm not a Ruby user, but I'm guessing references to googleapis in

https://github.com/lightningnetwork/lnd/blob/master/docs/grpc/ruby.md

can probably be removed as well.