search

lightningrodlabs / we-tauri

Creating a group coherence with holochain apps
https://lightningrodlabs.org/we
Other
43 stars 4 forks source link

multiple agents in group unaware of each other #19

Closed weswalla closed 1 year ago

weswalla commented 1 year ago

when I invite a second agent into the we group, the second agent successfully receives the invite and joins the group, but neither agent sees that the other one is in the group, and if one agent installs an applet, the other agents doesn't see it is the list of installed applets.

matthme commented 1 year ago

Hmm...I'll probably need to spend some time soon to make sure all things work properly again. I'll probably bump to holochain 0.1.0 in that case.

weswalla commented 1 year ago

@matthme I've made some progress on debugging this. It turns out that we are using the current time for origin time, even if joining a group: https://github.com/lightningrodlabs/we/blob/8ede52ae7b17ab463e011149579ea001fba72bcb/ui/app/src/matrix-store.ts#L928 which is leading to different cell ids. I removed that line to see what would happen when the cell id is the same, and I get these errors after joining the group:

Unhandled Promise Rejection: Error: No cell found with role_name status

Unhandled Promise Rejection: TypeError: this._store.agentsProfiles.get is not a function. (In 'this._store.agentsProfiles.get(this.agentPubKey)', 'this._store.agentsProfiles.get' is undefined)

Which seems to come from these depedencies:

    "@holochain-open-dev/peer-status": "^0.4.0",
    "@holochain-open-dev/profiles": "0.11.0",

I can confirm that both agents are in the same group now, as when I install an applet from one agent, it will show up in the Applets to Join list of the other agent, and joining it works.

I plan to continue debugging but just thought I would update for now, let me know if anything obvious comes to mind.

matthme commented 1 year ago

Thank you! Yes that makes total sense that the origin time should not be set when joining a group. The second issue I need to look into but it may potentially be related to an issue with the js-client that we saw yesterday in We (the js-client currently always overwrites the installed app id of an AppAgentWebsocket with the one it takes from window.__HC_LAUNCHER_ENV__ in the tauri window).

guillemcordoba commented 1 year ago

@matthme @weswalla take into account that this all will change by a lot in the upcoming refactor :hugs:

matthme commented 1 year ago

The invitation process has changed in the meantime, so I'm closing this now.