search

lightpanda-io / zig-v8-fork

MIT License
3 stars 0 forks source link

ci: build docker image with v8 lib #7

Closed krichprollsch closed 1 year ago

krichprollsch commented 1 year ago

depends on #9 relates to https://github.com/Browsercore/project/issues/45

krichprollsch commented 1 year ago

@francisbouvier the PR ir rebased. I have removed the scheduled build. I have also added a more detailed docker tag with v8 revision and zig version: https://github.com/Browsercore/zig-v8-fork/pull/7/files#diff-4d14704b6b88fb06db888f96c03a8e9b3a5e07a4ee566d97d4111b2c05210e84R60

francisbouvier commented 1 year ago

But here we do not have an "internal" version in the tag, no? Let's say we have added a new API wrapper function, but both v8 version and zig version are the same, how can we make the difference?

krichprollsch commented 1 year ago

@francisbouvier the internal tag version is handled by ${{steps.meta.outputs.version}} var. The value is created depending the context, here un a pull request trigger, it will be pr-7 but in tag trigger, it will be the tag itself. So yes, we will have an unique tag composed of this tag + zig + chrome version