lightphoenix2 / LPX

LPX for Rocket
5 stars 8 forks source link

License Issue #23

Open JustOneMoreBlock opened 8 years ago

JustOneMoreBlock commented 8 years ago

Issue: All vehicles get an ID when the server starts. Players buy vehicle licenses. Upon restart, the player either owns a different vehicle than originally authorized or can not get into the car they licensed.

Problem identification: During server restart destroyed vehicles are removed from the list, and the vehicle numbers are recycled. This results in a key number shift that also shifts ownership of the original vehicle.

Example: Player buys key 15. Car 10 is destroyed. On server restart, all cars after nine are renumbered. The owner of car 15 now owns car 14, an entirely different vehicle. The previous owner of car 16 now owns car 15. Neither player is happy with the change.

The more vehicles destroyed in the sequence, the greater the shift. Players are fortunate if they can reacquire their original vehicle under the shifted key number. This requires the player to be online during a restart to try to reacquire the vehicle license or risk losing their investment. This has also resulted in players buying/building many makeshift vehicles to get a vehicle. Even the makeshifts suffer from the numbering bug.

Resolution: Two possibilities:

1) All vehicles need unique IDs that do not change. Key numbers should never be recycled or shifted. While this results in a larger database, unique IDs would ensure the ownership of the vehicle not only through a server restart but right up until a full map reset. Key numbers would end up in the four and five digit range, not unlike item IDs. A reminder of the key number when the original purchaser jumps in is best instead of the "safe trip" message. Every key owner, except for the vehicle owner, gets to see the key number every trip.

2) The owner field moves the appropriate amount of spaces before the car list is renumbered. This would have the same effect as a unique vehicle ID but may be easier to accomplish. It would also keep vehicle ID numbers lower.

Benefits: Key prices could return to their original higher amount. This would lead to the need for fewer people to buy or build makeshift vehicles as only players who are going to stay on the server for several days or more would consider buying a vehicle. This would also result in fewer arguments over who owns a vehicle and fewer calls to staff to try and resolve an issue over which they have no control. The option is to disable the plugin and go back to having players claim vehicles by placing metal signs of ownership on them.

This is also part of #18 and #10 - You can close that one as this one has more details.

Reported by my Mod (Pete) and now I'm reporting to you!

Kind Regards, Cory