lightsail-network / java-stellar-sdk

The Java Stellar SDK library provides APIs to build transactions and connect to Horizon and Soroban-RPC Server.
https://javadoc.io/doc/network.lightsail/stellar-sdk
Apache License 2.0
175 stars 160 forks source link

Refactor #623

Closed overcat closed 3 months ago

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 90.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.96%. Comparing base (c780543) to head (7c23a20).

Files Patch % Lines
src/main/java/org/stellar/sdk/Asset.java 50.00% 0 Missing and 1 partial :warning:
src/main/java/org/stellar/sdk/TrustLineAsset.java 85.71% 0 Missing and 1 partial :warning:
.../sdk/operations/LiquidityPoolDepositOperation.java 87.50% 0 Missing and 1 partial :warning:
...sdk/operations/LiquidityPoolWithdrawOperation.java 87.50% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #623 +/- ## ============================================ + Coverage 77.77% 80.96% +3.19% - Complexity 1078 1161 +83 ============================================ Files 203 202 -1 Lines 4324 4335 +11 Branches 332 338 +6 ============================================ + Hits 3363 3510 +147 + Misses 763 623 -140 - Partials 198 202 +4 ``` | [Files](https://app.codecov.io/gh/lightsail-network/java-stellar-sdk/pull/623?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lightsail-network) | Coverage Δ | | |---|---|---| | [...main/java/org/stellar/sdk/AbstractTransaction.java](https://app.codecov.io/gh/lightsail-network/java-stellar-sdk/pull/623?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fstellar%2Fsdk%2FAbstractTransaction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lightsail-network#diff-c3JjL21haW4vamF2YS9vcmcvc3RlbGxhci9zZGsvQWJzdHJhY3RUcmFuc2FjdGlvbi5qYXZh) | `75.00% <ø> (ø)` | | | [.../java/org/stellar/sdk/AssetTypeCreditAlphaNum.java](https://app.codecov.io/gh/lightsail-network/java-stellar-sdk/pull/623?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fstellar%2Fsdk%2FAssetTypeCreditAlphaNum.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lightsail-network#diff-c3JjL21haW4vamF2YS9vcmcvc3RlbGxhci9zZGsvQXNzZXRUeXBlQ3JlZGl0QWxwaGFOdW0uamF2YQ==) | `0.00% <ø> (ø)` | | | [...ava/org/stellar/sdk/AssetTypeCreditAlphaNum12.java](https://app.codecov.io/gh/lightsail-network/java-stellar-sdk/pull/623?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fstellar%2Fsdk%2FAssetTypeCreditAlphaNum12.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lightsail-network#diff-c3JjL21haW4vamF2YS9vcmcvc3RlbGxhci9zZGsvQXNzZXRUeXBlQ3JlZGl0QWxwaGFOdW0xMi5qYXZh) | `87.50% <ø> (ø)` | | | [...java/org/stellar/sdk/AssetTypeCreditAlphaNum4.java](https://app.codecov.io/gh/lightsail-network/java-stellar-sdk/pull/623?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fstellar%2Fsdk%2FAssetTypeCreditAlphaNum4.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lightsail-network#diff-c3JjL21haW4vamF2YS9vcmcvc3RlbGxhci9zZGsvQXNzZXRUeXBlQ3JlZGl0QWxwaGFOdW00LmphdmE=) | `88.46% <ø> (ø)` | | | [src/main/java/org/stellar/sdk/AssetTypeNative.java](https://app.codecov.io/gh/lightsail-network/java-stellar-sdk/pull/623?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fstellar%2Fsdk%2FAssetTypeNative.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lightsail-network#diff-c3JjL21haW4vamF2YS9vcmcvc3RlbGxhci9zZGsvQXNzZXRUeXBlTmF0aXZlLmphdmE=) | `71.42% <ø> (ø)` | | | [src/main/java/org/stellar/sdk/Auth.java](https://app.codecov.io/gh/lightsail-network/java-stellar-sdk/pull/623?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fstellar%2Fsdk%2FAuth.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lightsail-network#diff-c3JjL21haW4vamF2YS9vcmcvc3RlbGxhci9zZGsvQXV0aC5qYXZh) | `83.11% <ø> (ø)` | | | [.../main/java/org/stellar/sdk/FeeBumpTransaction.java](https://app.codecov.io/gh/lightsail-network/java-stellar-sdk/pull/623?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fstellar%2Fsdk%2FFeeBumpTransaction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lightsail-network#diff-c3JjL21haW4vamF2YS9vcmcvc3RlbGxhci9zZGsvRmVlQnVtcFRyYW5zYWN0aW9uLmphdmE=) | `88.60% <ø> (ø)` | | | [src/main/java/org/stellar/sdk/KeyPair.java](https://app.codecov.io/gh/lightsail-network/java-stellar-sdk/pull/623?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fstellar%2Fsdk%2FKeyPair.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lightsail-network#diff-c3JjL21haW4vamF2YS9vcmcvc3RlbGxhci9zZGsvS2V5UGFpci5qYXZh) | `88.54% <ø> (ø)` | | | [src/main/java/org/stellar/sdk/LedgerBounds.java](https://app.codecov.io/gh/lightsail-network/java-stellar-sdk/pull/623?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fstellar%2Fsdk%2FLedgerBounds.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lightsail-network#diff-c3JjL21haW4vamF2YS9vcmcvc3RlbGxhci9zZGsvTGVkZ2VyQm91bmRzLmphdmE=) | `100.00% <100.00%> (+50.00%)` | :arrow_up: | | [src/main/java/org/stellar/sdk/LiquidityPool.java](https://app.codecov.io/gh/lightsail-network/java-stellar-sdk/pull/623?src=pr&el=tree&filepath=src%2Fmain%2Fjava%2Forg%2Fstellar%2Fsdk%2FLiquidityPool.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lightsail-network#diff-c3JjL21haW4vamF2YS9vcmcvc3RlbGxhci9zZGsvTGlxdWlkaXR5UG9vbC5qYXZh) | `80.64% <100.00%> (ø)` | | | ... and [22 more](https://app.codecov.io/gh/lightsail-network/java-stellar-sdk/pull/623?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lightsail-network) | | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/lightsail-network/java-stellar-sdk/pull/623/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lightsail-network)