Rectangular selection by click and drag

lightsheet-team / lightsheet

GNU Lesser General Public License v3.0

1 stars 1 forks source link

Rectangular selection by click and drag #116

Closed GimanthaDissanayake closed 5 months ago

GimanthaDissanayake commented 5 months ago

In this PR,

Extracted logic and implemented getRowColumnIndex method
Implemented mouse down and up event handlers
Implemented cell range selection logic and added styles
Implemented removingCellRangeSelection styles
Lint fixes

Fluglow commented 5 months ago

Not directly related to this PR, but do we need to track column/row keys in cell element IDs? It looks like it'd be simpler for the UI code to always use indices instead.

rafinutshaw commented 5 months ago

When i click n drag the cell where i start the drag from is always not colored selected. I can imagime it maybe becuse the cell is being editted hence it overwrites selected cell styling If its due to that we can create a new issue to make the cell's to enable edit only on double click.

GimanthaDissanayake commented 5 months ago

When i click n drag the cell where i start the drag from is always not colored selected. I can imagime it maybe becuse the cell is being editted hence it overwrites selected cell styling If its due to that we can create a new issue to make the cell's to enable edit only on double click.

This is handled with latest bug fix

GimanthaDissanayake commented 5 months ago

(Optional) There is one thing that i dont like and that is, to clearCellSelections we are looping through the whole table to remove the selected css class. I believe this can be optimized by only looping through the cells that in in the range of our selectionstart and selection end variables. But i am approving this anyway.

I will create a new issue for this, thanks.