Closed Yousif-FJ closed 5 months ago
an extra row is being created on load. I only put in data for 3 rows
an extra row is being created on load. I only put in data for 3 rows
This is because the default row and column is 4. I didn't change it, same as before.
an extra row is being created on load. I only put in data for 3 rows
This is because the default row and column is 4. I didn't change it, same as before.
Default column was only being used if no data was provided as in for emply table view. If data is present we generate the table based on data's row, column
an extra row is being created on load. I only put in data for 3 rows
This is because the default row and column is 4. I didn't change it, same as before.
Default column was only being used if no data was provided as in for emply table view. If data is present we generate the table based on data's row, column
Changed.
This PR fix issues with
SetCellAt
.SetCellAt
Did not work correctly previously and inserted incorrect element into the DOM in certain situations. I needSetCellAt
to work correctly for my other PRs.While I was trying to figure out the problem with that function, I had to refactor something.
Here are the main benefits of these changes:
SetCellAt
will work, in case the cell being set is outside the current default view layout (larger than the initial 4x4).AddColumn
andAddRow
function on the UI will allow us to easily expand the default row and column count.LighSheetOptions
defaultRowCount
anddefaultColCount
.UI
andmain.ts
, where previously the initial table was being created inmain.ts
while it being a UI concern.Additional tests were added + some fixes to other tests.