lightsheet-team / lightsheet

GNU Lesser General Public License v3.0
1 stars 1 forks source link

Fix set cell at and some refactoring #129

Closed Yousif-FJ closed 5 months ago

Yousif-FJ commented 5 months ago

This PR fix issues with SetCellAt. SetCellAt Did not work correctly previously and inserted incorrect element into the DOM in certain situations. I need SetCellAt to work correctly for my other PRs.

While I was trying to figure out the problem with that function, I had to refactor something.

Here are the main benefits of these changes:

Additional tests were added + some fixes to other tests.

rafinutshaw commented 5 months ago

image an extra row is being created on load. I only put in data for 3 rows

Yousif-FJ commented 5 months ago

image an extra row is being created on load. I only put in data for 3 rows

This is because the default row and column is 4. I didn't change it, same as before.

rafinutshaw commented 5 months ago

image an extra row is being created on load. I only put in data for 3 rows

This is because the default row and column is 4. I didn't change it, same as before.

Default column was only being used if no data was provided as in for emply table view. If data is present we generate the table based on data's row, column

Yousif-FJ commented 5 months ago

image an extra row is being created on load. I only put in data for 3 rows

This is because the default row and column is 4. I didn't change it, same as before.

Default column was only being used if no data was provided as in for emply table view. If data is present we generate the table based on data's row, column

Changed.