search

lightsources / BES-XPCS-Pilot

Work with BES Data Science Team to develop Python code to write NeXus data file with proposed NeXus definitions.
0 stars 0 forks source link

remove `mask` from entry/xpcs/masks/mask #53

Closed ambarb closed 3 years ago

ambarb commented 3 years ago

need to confirm

image

ambarb commented 3 years ago

seems #57 page 13 says "bin" --> "roi"

The reader's digest justification is python library uses roi in a more general context and not in the way that certain AreaDetector plugins work.

ambarb commented 3 years ago

@JulReinhardt is this taken care of by your PR?

ambarb commented 3 years ago

from discussion with @prjemian , this mask was added with @ronpandolfi in early days of the project. We think this is redundant and we verify that it can be deleted.

@JulReinhardt will verify that it is gone and we can move this to complete when that happens.

prjemian commented 3 years ago

Waiting for PR #52 to merge.