generate a list of required that should be optional and vice versa

ambarb commented 3 years ago

not required using Pete's NXxpcs mock webpage

If required means the field is required, but the field doesn't require a value, then maybe this is not essential.

[x] anything associated with 2-time or twotime. it isn't always calculated depending on choices of user doing the experiment.
[x] g2_errors https://github.com/lightsources/BES-XPCS-Pilot/blob/562404d66915d5bd3e1194329be176b0756d4592/NeXus/NXxpcs.nxdl.xml#L90
[x] dphilist, sqmap, sqlist. --> dynamic_phi_list , static_roi_map , static_q_list
[x] sample\position_x and_y and _z . depending on instrument and experimental setup these details may be irrelevant
[x] MORE???

ambarb commented 3 years ago

@prjemian I am happy to contribute to PR if we need to addres it. Can you answer my question about the meaning of "required"

prjemian commented 3 years ago

required means the field must be present and a value of the expected data type must be provided

We can make such fields optional if a value is not always expected to be available. (not truly required)

ambarb commented 3 years ago

@ambarb to make sure the list is complete.

ambarb commented 3 years ago

ambarb commented 3 years ago

we all believe that we are done (with pushes)

if there are more, they will come up in our XPCS community review.

lightsources / BES-XPCS-Pilot