MNT #43 replace NXmonochromator with NXbeam

lightsources / BES-XPCS-Pilot

Work with BES Data Science Team to develop Python code to write NeXus data file with proposed NeXus definitions.

0 stars 0 forks source link

MNT #43 replace NXmonochromator with NXbeam #61

Closed prjemian closed 3 years ago

prjemian commented 3 years ago

Fix #43 by:

replacing monochromatorNXmonochromator (NXmonochromator) group with incident_beam (NXbeam) group
relocating monochromator/energy into incident_beam/incident_energy (consistent with NeXus field name)
creating incident_beam/incident_polarization (consistent with NeXus field name)

prjemian commented 3 years ago

This is ready for review.

prjemian commented 3 years ago

There is a NXsample/distance field but this is different from optics-sample distance. Still, I believe this field belongs in the NXsample group (which be in a different issue).

prjemian commented 3 years ago

We made some changes in the check list (above) today. I'll update this PR. incident_energy_spread and extent

prjemian commented 3 years ago

@JulReinhardt , @ambarb , @AbbyGi : We must change incident_polarization to a different name since NeXus NXbeam uses incident_polarization to describe numerical values. We say this term should be descriptive text.

incident_polarization --> incident_polarization_type

Fortunately, this change will not affect any other code we have now:

(base) prjemian@zap:~/.../xpcs/NeXus$ git grep incident_polarization
NXxpcs.nxdl.xml:        <field name="incident_polarization">

prjemian commented 3 years ago

And, this file is out of sync with master branch. Must first wait for PR #52.

prjemian commented 3 years ago

@ambarb ready for your review