search

lightspeedretail / webstore

Web Store eCommerce solution for Lightspeed
http://www.lightspeedpos.com/webstore
Open Software License 3.0
85 stars 63 forks source link

WYSIWYG Custom page editor strips paragraph tags... #585

Closed noahkuhn closed 10 years ago

noahkuhn commented 10 years ago

This is really annoying. Whatever WYSIWYG is being used strips paragraph tags, even though the editor buttons allow you to create them and you can create them via HTML mode. This needs to be fixed.

noahkuhn commented 10 years ago

Anyone who cares to change this functionality:

/core/protected/modules/admin/views/custompage/edit.php

Line 103

'linebreaks'=>false

ktwbc commented 10 years ago

The linebreaks functionality isn't really explicitly adding or stripping

functionality, that may be a side effect of what it's intended for. As documented http://imperavi.com/redactor/docs/settings/#set-linebreaks, linebreaks=true will use
tags to convert regular CR and if false (which is default on the system) it will use

.

However, this feature was rewritten for 3.1 due to some multilanguage features (WS-1136) so we can double check this.

noahkuhn commented 10 years ago

"In linebreaks mode, Redactor will markup text with "br" tag. Otherwise, Redactor will markup text with paragraphs."

This seems to suggest that the default is paragraphs, but if linebreaks: true is set, then paragraphs are not used and line endings are merely done as line break tags.

So yes, it's not stripping, it's simply not adding them as the default setup would have. The problem arises if you have styles set on paragraphs (font size or margin whatever) as the text isn't coded as a paragraph and thus falls all the way back to whatever font CSS is attached to the parent of that text, which I'd assume is usually the body tag.

ktwbc commented 10 years ago

Filed as item WS-1136

ktwbc commented 10 years ago

WS-1136 fixed as of WS 3.1.0