search

lightspeedretail / webstore

Web Store eCommerce solution for Lightspeed
http://www.lightspeedpos.com/webstore
Open Software License 3.0
85 stars 63 forks source link

Removing family doesn't remove from webstore #617

Closed hakonorri closed 9 years ago

hakonorri commented 10 years ago

When I hover over BRANDS (or families) on my website I only see the brands that have products that have items for sale on the webstore. So when a product is sold out the link disappears. This is what I like.

I added a new family in my LIghtspeed when preparing for receiving a new brand. The family appears in http://lalujo.se/brand/%2A (in Brooklyn theme) even though I haven't added a single product to that family. Also in that link I can see "old" families that are sold-out or abandoned.

I removed the new family from LIghtspeed but the family wasn't removed from the Webstore. I had to go into the database to remove it.

Shouldn't http://lalujo.se/brand/%2A show the same brands as when I hover over the Brands link?

brandinchiu commented 10 years ago

There is a tool in the admin panel for handling this. For the most part, it looks like the web store upload is one-way. If you delete a product from LightSpeed, web store hangs onto it too (which is why they should be marked non current or non web).

You can access this tool from System->Purge Deleted Categories/Families.

Obviously, this same thing can be for categories.

(Just note, that no product can point to the family or category you wish to delete, even non-current, non-web, or inventoryless products. You must move all products to a new family/category first)

hakonorri commented 10 years ago

Thanks. I had forgotten about the purge.

Still the page /brand/%2A is showing brands that I haven't been available for long, since they are sold out and I will not order again (opposite to what the on-mouse-over does in the menu).

(on the note, it was all new families that I was preparing for products arriving in a few months so there were no products yet.)

brandinchiu commented 10 years ago

How are you displaying the brands on your brand page? The menu is drawing them and filtering them through another method which I believe checks for products. If this is just the stock Web Store behaviour, it may just be set up to display all brands at that point.

hakonorri commented 10 years ago

I have a complete standard 3.1.6. I have chosen: Display empty categories = OFF but I can't find anything similar about Families/brands

brandinchiu commented 10 years ago

I ran through a quick search of the Controller and it looks like it doesn't filter them out at that level. There also isn't really a view file for you to modify either. You would need to override the SearchController (which is pretty messy, I wouldn't recommend it) to get the desired results.

You may just have to try to leave empty Families out of your upload until you have products in them.

(Depending how comfortable you are with modifying template files, there is another "hacky" way you could prevent this)

hakonorri commented 10 years ago

I don't think I will go into the code. It is not a big issue for me at the moment. But there are others that have the same issue: http://ideas.lightspeedretail.com/forums/20894-lightspeed-pro/suggestions/5485889-do-not-display-families-that-do-not-have-inventory

brandinchiu commented 10 years ago

Yeah, looks like this is something that will need to be addressed in further updates.

hakonorri commented 10 years ago

well. Thanks for the talk. You can close the Issue or however convenient.

brandinchiu commented 10 years ago

I'm not actually an employee of LightSpeed, haha. Just a casual observer looking to help where I can. I can't close the ticket : )

hakonorri commented 10 years ago

nice job :) I will keep it open then.

gabeguz commented 9 years ago

We are tracking this issue internally as WS-51.

ottaz commented 9 years ago

This has been fixed as of version 3.2.7.