lightspeedwp / lsx

LSX is an flexible, light-weight, minimalistic and responsive theme designed to empower makers to build beautifully rich websites with WordPress block editor. The theme displays perfectly on all desktop & mobile devices.
https://lsdev.biz/lsx/
GNU General Public License v3.0
34 stars 3 forks source link

Find a better way to make the lsx-full-width section full width #239

Closed viscosho closed 4 years ago

viscosho commented 4 years ago

Describe the bug The Google Search Console is showing an error saying “Content wider than screen” for the Google Mobile Friendly test, the reason this error occurs is because lsx uses these type of clases to make full width sections inside the main content to be full width:

.content-area .lsx-full-width-base, .content-area .lsx-full-width-base-small, .content-area .lsx-full-width, .content-area .lsx-full-width-alt {
    margin: 0 -9999rem;
    padding: 8.5rem 9999rem;
}

There should be a better way to achieve these full sections.

To Reproduce This will happen to any div or section that sues the clases .lsx-full-width-base, .lsx-full-width-base-small, lsx-full-width or .lsx-full-width-alt, which happens a lot in all our extensions and themes.

Here is one of our clients live sites giving the error: https://search.google.com/test/mobile-friendly?id=8N-HKFa7flAdhZxA0nmZjg

Expected behaviour The sections using these classes should still be full width content inside the main container.

Screenshots

Full width section from TO

Screen Shot 2019-11-19 at 5 37 37 PM

Desktop Happening in all browsers

Mobile Happening in device

viscosho commented 4 years ago

This has has been created with the purpose if fixing this issue: https://github.com/lightspeeddevelopment/lsx/tree/mobile-fix-content-wider-than-screen

viscosho commented 4 years ago

This has been fixed and tested in this commit: https://github.com/lightspeeddevelopment/lsx/commit/d8562c4dc3523fa76fde845429e6517cc4734bfa